fix: separate repeated steps as individual functions #562
Conversation
…vm-debugger Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # test/e2e/commands/node-local-ptt.test.mjs
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…vm-debugger Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # src/commands/node.mjs
…vm-debugger Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # src/commands/flags.mjs # src/commands/network.mjs
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Unit Test Results - Linux 1 files 19 suites 27s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
Unit Test Results - Windows 1 files 19 suites 53s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
E2E Node PEM Stop Tests Coverage Report13 tests 13 ✅ 2m 37s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
E2E Relay Tests Coverage Report1 files 1 suites 2m 43s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
E2E Node PEM Kill Tests Coverage Report13 tests 13 ✅ 2m 58s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
E2E Mirror Node Tests Coverage Report 1 files 1 suites 3m 50s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
E2E Node Local Build Tests Coverage Report10 tests 10 ✅ 2m 33s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
E2E Tests Coverage Report58 tests 58 ✅ 4m 23s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
E2E Node Update Tests Coverage Report12 tests 12 ✅ 4m 36s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
E2E Node Delete Tests Coverage Report10 tests 10 ✅ 5m 48s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
E2E Node Add Tests Coverage Report22 tests 22 ✅ 12m 1s ⏱️ Results for commit 2df8689. ♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
- Coverage 83.15% 82.60% -0.56%
==========================================
Files 36 36
Lines 4815 4714 -101
Branches 667 749 +82
==========================================
- Hits 4004 3894 -110
- Misses 811 820 +9
... and 3 files with indirect coverage changes |
|
LGTM, but I want to let @Ivo-Yankov merge #533 first, as we need that for Simi's team. |
## [0.30.0](v0.29.0...v0.30.0) (2024-09-17) ### Features * add node add-prepare and node add-execute commands ([#533](#533)) ([a184775](a184775)) * add support for attach jvm debugger ([#549](#549)) ([35a0075](35a0075)) * add the autogen tool to easily add e2e tests and run it for the first time & fix copyFrom ([#566](#566)) ([e6c79eb](e6c79eb)) * **network node livecheck:** implement a functionality to determine network node activeness with prometheus metrics ([#567](#567)) ([6120775](6120775)) * remove pfx support ([#537](#537)) ([aff5f63](aff5f63)) ### Bug Fixes * aligned test names to naming pattern ([#554](#554)) ([365f724](365f724)) * download application.properties file if it was generated by hedera app during handling address book change ([#571](#571)) ([35c73d8](35c73d8)) * **functionality:** removed the 'z' from the 'tar' command on the K8.copyFrom ([#561](#561)) ([796474b](796474b)) * have update readme run after version calculation in deploy and release ([#586](#586)) ([42e1685](42e1685)) * jsdoc errors due to unrecognized format ([#557](#557)) ([da7113b](da7113b)) * remove of using agreement key in hedera repo test ([#563](#563)) ([05c5517](05c5517)) * separate repeated steps as individual functions ([#562](#562)) ([dcbbe5e](dcbbe5e))
|
🎉 This PR is included in version 0.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This pull request changes the following:
Related Issues